Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDS-6005] Notify MMO on report submission for 10.4.4(g) #3131

Merged
merged 2 commits into from
May 30, 2024
Merged

[MDS-6005] Notify MMO on report submission for 10.4.4(g) #3131

merged 2 commits into from
May 30, 2024

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented May 30, 2024

Objective

MDS-6005

  • Just to note something I thought was strange: perm recl does not get an email sent without the entry in mine_report_notification which is added by the migration (and this is the only record that references that contact) but with it, it sends twice
  • once to PermRecl@gov.bc.ca and again to permrecl@gov.bc.ca
  • I decided that this was probably a can of worms though- I tested emailing myself with different upper/lower and only got it once so I concluded that this is fine. Couple things that might be causing this that I didn't want to change the logic for:
    • we have two defined constants for this same email, MAJOR_MINES_OFFICE_EMAIL, and PERM_RECL_EMAIL (and it's also in emli_contacts table)
    • mine_report.py-->getReportSpecificEmailsByReportType: looks like it adds PERM_RECL for major mines but only if there are contacts associated with the compliance article
    • and also there is no lower-casing in the comparison to see if an email is already in the list

Why are you making this change? Provide a short explanation and/or screenshots

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@taraepp taraepp changed the title make 10.4.4.g not prr-only, and set it to notify perm_recl [MDS-6005] Notify MMO on report submission for 10.4.4(g) May 30, 2024
matbusby-fw
matbusby-fw approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@taraepp taraepp merged commit 8ac1850 into develop May 30, 2024
11 of 12 checks passed
@taraepp taraepp deleted the mds-6005-add-permrecl-to-10-4-4-g-notification branch May 30, 2024 23:46
simensma-fresh pushed a commit that referenced this pull request Jun 12, 2024
@taraepp @simensma-fresh
[MDS-6005] Notify MMO on report submission for 10.4.4(g) (#3131)
523388f 
* make 10.4.4.g not prr-only, and set it to notify perm_recl

* don't send to permrecl for regional mines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asinn134 asinn134 asinn134 approved these changes

@isuru-aot isuru-aot isuru-aot approved these changes

@matbusby-fw matbusby-fw matbusby-fw approved these changes

@henryoforeh-dev henryoforeh-dev henryoforeh-dev approved these changes

@simensma-fresh simensma-fresh Awaiting requested review from simensma-fresh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@taraepp @henryoforeh-dev @matbusby-fw @isuru-aot @asinn134